Skip to content

Commit

Permalink
Remove the --prune_cpp_modules command line option.
Browse files Browse the repository at this point in the history
Bazel builds generally don't use modules, so this was a no-op and it's mysterious enough that I'm reasonably confident that no one used it in Bazel (and a Google search agrees)

RELNOTES[INC]: The --prune_cpp_modules command line option is not supported anymore.

PiperOrigin-RevId: 217134320
  • Loading branch information
lberki authored and Copybara-Service committed Oct 15, 2018
1 parent cffe0e3 commit 21c975d
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ private boolean useHeaderModules() {
}

private boolean shouldPruneModules() {
return cppConfiguration.getPruneCppModules() && shouldScanIncludes && useHeaderModules();
return shouldScanIncludes && useHeaderModules();
}

private void verifyActionIncludePaths(CppCompileAction action, Consumer<String> errorReporter) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -922,10 +922,6 @@ public boolean getInmemoryDotdFiles() {
return cppOptions.inmemoryDotdFiles;
}

public boolean getPruneCppModules() {
return cppOptions.pruneCppModules;
}

public boolean getPruneCppInputDiscovery() {
return cppOptions.pruneCppInputDiscovery;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -646,19 +646,6 @@ public Label getFdoPrefetchHintsLabel() {
)
public boolean inmemoryDotdFiles;

@Option(
name = "prune_cpp_modules",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.BUILD_TIME_OPTIMIZATION,
effectTags = {
OptionEffectTag.LOADING_AND_ANALYSIS,
OptionEffectTag.EXECUTION,
OptionEffectTag.CHANGES_INPUTS
},
help = "If enabled, use the results of input discovery to reduce the number of used modules."
)
public boolean pruneCppModules;

@Option(
name = "experimental_prune_cpp_input_discovery",
defaultValue = "false",
Expand Down

0 comments on commit 21c975d

Please sign in to comment.