Skip to content

Commit

Permalink
Rename --experimental_remote_cache_compression to `--remote_cache_c…
Browse files Browse the repository at this point in the history
…ompression`

We (and most of our customers) been using this in production for a long time, and at least since 6.0 haven’t run into any issue. It should no longer be marked experimental.

RELNOTES: `--experimental_remote_cache_compression` has been renamed to `--remote_cache_compression`

Closes #17990.

PiperOrigin-RevId: 523934013
Change-Id: I397f0b3b45dc11e7d6bbb28b043c41dad0843c59
  • Loading branch information
brentleyjones authored and copybara-github committed Apr 13, 2023
1 parent 0e8e611 commit 0cdd409
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,7 @@ public static ClientServerCompatibilityStatus checkClientServerCompatibility(
if (remoteOptions.cacheCompression
&& !cacheCap.getSupportedCompressorsList().contains(Compressor.Value.ZSTD)) {
result.addError(
"--experimental_remote_cache_compression requested but remote does not support"
+ " compression");
"--remote_cache_compression requested but remote does not support compression");
}

// Check result cache priority is in the supported range.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,8 @@ public RemoteBuildEventUploadModeConverter() {
public boolean incompatibleRemoteDanglingSymlinks;

@Option(
name = "experimental_remote_cache_compression",
name = "remote_cache_compression",
oldName = "experimental_remote_cache_compression",
defaultValue = "false",
documentationCategory = OptionDocumentationCategory.REMOTE,
effectTags = {OptionEffectTag.UNKNOWN},
Expand Down

0 comments on commit 0cdd409

Please sign in to comment.