Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] bzlmod & go.work #1731

Merged

Commits on Apr 18, 2024

  1. [Feature] bzlmod & go.work

    * adds go_deps.from_file(go_work = "//:go.work")
    * adds ability to op-out of version conflict failures go_deps.from_file(go_work = "//:go.work, fail_on_version_conflict = False)
    * parses go.work files to discover used go modules and replace statements
    * generates repos for all deps specified in go.mod's referenced by the //:go.work
    * handle replace statements (both at the go.work and the go.mod level)
    * Errors with actionable error message if duplicate dependencies with differing versions arise (Question: can we do better?)
    * expand BCR test coverage to include both go.work and go.mod scenarios
    
    Caveats:
    * allows for dependency bleed between different go modules in the workspace - this is sorta by design for this stepping stone, but is ideal
    * doesn't support replace statements in go.work yet (but that shouldn't be to hard to add in a follow up)
    stefanpenner authored and Stefan Penner committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    c292df3 View commit details
    Browse the repository at this point in the history