Add javacc and javaparser #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (javacc, javaparser) have been updated in this PR. Please review the changes. |
fmeum
previously approved these changes
Sep 6, 2024
auto-merge was automatically disabled
September 6, 2024 12:23
Head branch was pushed to by a user without write access
jmillikin
force-pushed
the
add-javacc-and-javaparser
branch
from
2b0931d
to
775d4df
Compare
bazel-io
dismissed
fmeum’s stale review
Require module maintainers' approval for newly pushed changes.
|
It seems that JavaParser is incompatible with JDK versions 21 and later: javaparser/javaparser#4022 I've updated |
fmeum
added
the
presubmit-auto-run
auto-merge was automatically disabled
September 6, 2024 15:11
Head branch was pushed to by a user without write access
|
Bumped CI is now (mercifully) green. |
fmeum
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.