Add Apple CC toolchain setup #113

keith · 2022-03-23T23:16:11Z

This migrates the Apple CC toolchain from bazel into this repo. This allows this to evolve and be updated without a full bazel udpate. Bazel's built in unix toolchain can still be used to build macOS C++ targets, but this repo handles a wider variety of Apple specific flags and requires you have Xcode installed.

keith · 2022-03-23T23:16:27Z

Investigation related to bazelbuild/bazel#15041 (comment)

We can likely simplify this later

If you're calling this you want Xcode

keith · 2023-01-12T21:38:52Z

Overview / approach of changes:

I copied all the macOS toolchain setup I could from bazel without changing it, so most files like wrapped_clang, xcrunwrapper etc have 0 changes
I moved all the tests that required non-macOS only support, or relied on actually building objc, without changing them (objc_test.sh, apple_test.sh, the relevant helpers)
I fixed buildifier violations as needed
I copied the file that is now setup.bzl but changed it significantly since we don't need to handle the same sort of multi-os fallbacks
I plan to cleanup some things like unnecessary env vars later so we can have more clear history on why they're not needed etc

crosstool/setup.bzl

README.md

crosstool/setup.bzl

Co-authored-by: Thi Doãn <t@thi.im>

crosstool/BUILD.toolchains

crosstool/setup.bzl

This moves the CC toolchain for building Apple platforms besides macOS to the apple_support repo bazelbuild/apple_support#113 The default unix toolchain is now used if someone wants to build for macOS without the apple_support toolchain, but it doesn't handle as many platform specific features as the previous toolchain. Fixes #15041 Closes #16619. PiperOrigin-RevId: 515546196 Change-Id: Ia54b53e7093c1edbfe8276730aaed5a11a94a027

*** Reason for rollback *** Breaks builds internally. *** Original change description *** Move Apple toolchain setup to apple_support This moves the CC toolchain for building Apple platforms besides macOS to the apple_support repo bazelbuild/apple_support#113 The default unix toolchain is now used if someone wants to build for macOS without the apple_support toolchain, but it doesn't handle as many platform specific features as the previous toolchain. Fixes #1... *** PiperOrigin-RevId: 516486823 Change-Id: If9b2542699cf8704e0a511e684d8519468ddd937

*** Reason for rollback *** Roll forward with fix *** Original change description *** Automated rollback of commit d56dc18. *** Reason for rollback *** Breaks builds internally. *** Original change description *** Move Apple toolchain setup to apple_support This moves the CC toolchain for building Apple platforms besides macOS to the apple_support repo bazelbuild/apple_support#113 The default unix toolchain is now used if someone wants to build for macOS without the apple_support toolc *** PiperOrigin-RevId: 518560017 Change-Id: I00a106b68eac982e3d903531d5db48ae053f9301

This moves the CC toolchain for building Apple platforms besides macOS to the apple_support repo bazelbuild/apple_support#113 The default unix toolchain is now used if someone wants to build for macOS without the apple_support toolchain, but it doesn't handle as many platform specific features as the previous toolchain. Fixes bazelbuild#15041 Closes bazelbuild#16619. PiperOrigin-RevId: 515546196 Change-Id: Ia54b53e7093c1edbfe8276730aaed5a11a94a027

*** Reason for rollback *** Breaks builds internally. *** Original change description *** Move Apple toolchain setup to apple_support This moves the CC toolchain for building Apple platforms besides macOS to the apple_support repo bazelbuild/apple_support#113 The default unix toolchain is now used if someone wants to build for macOS without the apple_support toolchain, but it doesn't handle as many platform specific features as the previous toolchain. Fixes bazelbuild#1... *** PiperOrigin-RevId: 516486823 Change-Id: If9b2542699cf8704e0a511e684d8519468ddd937

*** Reason for rollback *** Roll forward with fix *** Original change description *** Automated rollback of commit d56dc18. *** Reason for rollback *** Breaks builds internally. *** Original change description *** Move Apple toolchain setup to apple_support This moves the CC toolchain for building Apple platforms besides macOS to the apple_support repo bazelbuild/apple_support#113 The default unix toolchain is now used if someone wants to build for macOS without the apple_support toolc *** PiperOrigin-RevId: 518560017 Change-Id: I00a106b68eac982e3d903531d5db48ae053f9301

keith mentioned this pull request Mar 23, 2022

iOS platform constraints locations bazelbuild/bazel#15041

Closed

keith marked this pull request as ready for review July 6, 2022 19:03

keith requested review from BalestraPatrick, brentleyjones, segiddins and thii as code owners July 6, 2022 19:03

keith marked this pull request as draft July 6, 2022 19:04

keith mentioned this pull request Nov 1, 2022

Move Apple toolchain setup to apple_support bazelbuild/bazel#16619

Closed

keith force-pushed the ks/add-example-toolchains-setup branch from 711b8e5 to 65e700a Compare November 2, 2022 23:26

keith force-pushed the ks/add-example-toolchains-setup branch 2 times, most recently from e7c43f0 to 010569f Compare January 11, 2023 00:56

keith changed the title ~~Add example toolchains setup~~ Add Apple CC toolchain setup Jan 12, 2023

bazelbuild deleted a comment from lyft-lint-bot Jan 12, 2023

keith added 16 commits January 12, 2023 13:22

Add example toolchains setup

04a6e15

Add other var back

92d9c69

Initial mv of crosstool setup

8e953ad

First pass setup

a5bb6c3

Remove separate osx_archs.bzl

6bb507e

Fixup for moved files, fallback to builtin version

029317d

Make crosstool tests pass

a0afb2d

We can likely simplify this later

Fix buildifier

c395f9e

sync with upstream

245e052

Use @local_config_apple_cc for repo

28f9f2e

buildifier

a982d7b

Add some initial device vs sim constraints

5c2112d

Add initial tests

7e7eb22

Move more tests

f946429

Enable objc_compile for detection

978e770

Add test filegroups

b80b588

keith added 12 commits January 12, 2023 13:23

sync upstream no dynamic_lookup

0462476

Remove unnecessary Xcode logic

76acb02

If you're calling this you want Xcode

Fix setup to not mirror upstream

eec7cd7

no rules_cc

2889c5b

bzlmod support

1d59f22

minor todos

48d65d5

lint

0224914

format

121c3c8

names

c3588f4

dup

526a361

all

d1f735d

update readme

2a3bb18

keith force-pushed the ks/add-example-toolchains-setup branch from c55baea to 2a3bb18 Compare January 12, 2023 21:37

more

badab2b

keith marked this pull request as ready for review January 12, 2023 21:38

add env var

c54b4d7

thii reviewed Jan 13, 2023

View reviewed changes

crosstool/setup.bzl Outdated Show resolved Hide resolved

crosstool/setup.bzl Outdated Show resolved Hide resolved

crosstool/setup.bzl Show resolved Hide resolved

README.md Show resolved Hide resolved

crosstool/setup.bzl Show resolved Hide resolved

keith and others added 2 commits January 13, 2023 06:43

Update crosstool/setup.bzl

77ad32f

Co-authored-by: Thi Doãn <t@thi.im>

Update crosstool/setup.bzl

7a01a5e

Co-authored-by: Thi Doãn <t@thi.im>

brentleyjones approved these changes Jan 17, 2023

View reviewed changes

crosstool/BUILD.toolchains Show resolved Hide resolved

crosstool/setup.bzl Show resolved Hide resolved

keith merged commit 311cc83 into master Jan 17, 2023

keith deleted the ks/add-example-toolchains-setup branch January 17, 2023 22:09

phst mentioned this pull request Jan 5, 2024

Coverage on macOS doesn't work with BAZEL_USE_CPP_ONLY_TOOLCHAIN bazelbuild/bazel#14970

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Apple CC toolchain setup #113

Add Apple CC toolchain setup #113

keith commented Mar 23, 2022 •

edited

Loading

keith commented Mar 23, 2022

keith commented Jan 12, 2023

Add Apple CC toolchain setup #113

Add Apple CC toolchain setup #113

Conversation

keith commented Mar 23, 2022 • edited Loading

keith commented Mar 23, 2022

keith commented Jan 12, 2023

keith commented Mar 23, 2022 •

edited

Loading