Support Bazel ObjcProvider compile_info migration #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparise
force-pushed
the
bazel-objc-migration
branch
2 times, most recently
from
3a386c0
to
dbfa526
Compare
This represents the minimal set of changes to get this project through the upstream Bazel project's ObjcProvider migration: bazelbuild/bazel#10674 In addition to updating our direct WORKSPACE dependencies, it also bumps the commit reference to our (quite stale) Tulsi fork that now contains these cherry-picked upstream commits: Branch: xchammer-0.28.1 - pinterest/tulsi@432cdb6 - pinterest/tulsi@62cfb95 - pinterest/tulsi@131e87b Branch: xchammer-3.4.1 - pinterest/tulsi@3d4f37a - pinterest/tulsi@a44bc1c - pinterest/tulsi@0c7ae95
jparise
force-pushed
the
bazel-objc-migration
branch
from
dbfa526
to
51a9f81
Compare
|
The test failure has been there for a while now and will need to be addressed separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This represents the minimal set of changes to get this project through
the upstream Bazel project's ObjcProvider migration:
bazelbuild/bazel#10674
In addition to updating our direct WORKSPACE dependencies, it also bumps
the commit reference to our (quite stale) Tulsi fork that now contains
these cherry-picked upstream commits:
Branch: xchammer-0.28.1
Branch: xchammer-3.4.1