Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNR] Move CI to Bazel 7 #797

Conversation

mattrobmattrob
Copy link
Collaborator

@mattrobmattrob mattrobmattrob commented Oct 30, 2023

Testing for #795.

mattrobmattrob added a commit that referenced this pull request Oct 30, 2023
Fixes #795. Bazel 7 seems to validate the usage of non-defined attributes better than Bazel 6 and lower.

~Testing Bazel 7 in CI using #797 This gets us one step closer to being prepared for Bazel 7.

Signed-off-by: Matt Robinson <mattrob@hey.com>
rules/app.bzl Outdated Show resolved Hide resolved
@mattrobmattrob mattrobmattrob force-pushed the mr/fix.output_discriminator.usage-bazel7 branch from 8845a89 to 0b8f9fc Compare October 30, 2023 23:59
@mattrobmattrob mattrobmattrob changed the title [DNR] Remove missing output_discriminator attribute usage [DNR] Move CI to Bazel 7 Oct 31, 2023
@mattrobmattrob mattrobmattrob force-pushed the mr/fix.output_discriminator.usage-bazel7 branch from 8958503 to 6c3f03f Compare December 7, 2023 14:18
Signed-off-by: Matt Robinson <mattrob@hey.com>
@mattrobmattrob mattrobmattrob force-pushed the mr/fix.output_discriminator.usage-bazel7 branch from 6c3f03f to 00eb116 Compare December 14, 2023 18:33
@mattrobmattrob mattrobmattrob mentioned this pull request Dec 14, 2023
7 tasks
@mattrobmattrob
Copy link
Collaborator Author

Closing since this is being worked on by @karim-alweheshy and others.

@mattrobmattrob mattrobmattrob deleted the mr/fix.output_discriminator.usage-bazel7 branch January 3, 2024 14:31
nataliejameson pushed a commit to discord/rules_ios that referenced this pull request Aug 13, 2024
Fixes bazel-ios/rules_ios#795. Bazel 7 seems to validate the usage of non-defined attributes better than Bazel 6 and lower.

~Testing Bazel 7 in CI using bazel-ios/rules_ios#797 This gets us one step closer to being prepared for Bazel 7.

Signed-off-by: Matt Robinson <mattrob@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants