Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump rules_swift to HEAD #246

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Bump rules_swift to HEAD #246

merged 2 commits into from
Jun 9, 2021

Conversation

jerrymarino
Copy link
Contributor

@jerrymarino jerrymarino commented Jun 2, 2021 •
edited by justinseanmartin
Loading

Now it works without worker.

@jerrymarino jerrymarino changed the title [Hold] bump rules_swift latest rev of IWBV2 [Hold] bump rules_swift to latest rev of IWBV2 Jun 2, 2021
@jerrymarino
Bump rules_swift to HEAD
c94265c 
Now it works without worker.

- Add the updated flag for IWBV2
- Remove index-import as it's now baked in

This drops the fork of rules_swift
@jerrymarino jerrymarino changed the title [Hold] bump rules_swift to latest rev of IWBV2 Bump rules_swift to HEAD Jun 9, 2021
@jerrymarino jerrymarino mentioned this pull request Jun 9, 2021
Merged
@jerrymarino
Copy link
Contributor Author

PS: CI issues looks like we're probably hitting our quiplash from yesterday

2021-06-09 17:47:48,662 Failed to launch test on simulator. Will relaunch again.
xcodebuild: error: Existing file at -resultBundlePath "/var/tmp/_bazel_runner/c2342bca25695567c8c3f3be166b56b3/sandbox/darwin-sandbox/1286/execroot/build_bazel_rules_ios/bazel-out/darwin-dbg/testlogs/tests/ios/unit-test/ExplicitHosted/test.outputs/test.xcresult"

2021-06-09 17:47:50,048 Failed to launch test on simulator. Will relaunch again.
xcodebuild: error: Existing file at -resultBundlePath "/var/tmp/_bazel_runner/c2342bca25695567c8c3f3be166b56b3/sandbox/darwin-sandbox/1286/execroot/build_bazel_rules_ios/bazel-out/darwin-dbg/testlogs/tests/ios/unit-test/ExplicitHosted/test.outputs/test.xcresult"

@jerrymarino
Copy link
Contributor Author

Also it looks like an old bug in xctestrunner where it'd leave a result bundle and blow up retries

@jerrymarino jerrymarino mentioned this pull request Jun 9, 2021
Open
@jerrymarino jerrymarino merged commit 52ced19 into master Jun 9, 2021
@jerrymarino jerrymarino deleted the jmarino/update_rules_swift branch June 9, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinseanmartin justinseanmartin justinseanmartin approved these changes

@thiagohmcruz thiagohmcruz thiagohmcruz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerrymarino @justinseanmartin @thiagohmcruz