Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The defines field should be populated from the deps compilation_context #231

Merged
merged 1 commit into from
Mar 30, 2021
Merged

The defines field should be populated from the deps compilation_context #231

merged 1 commit into from
Mar 30, 2021

Conversation

amberdixon
Copy link
Collaborator

According to bazelbuild/bazel#10674, the old define field on the ObjcProvider is now the defines field on CompilationContext.

Related to https://github.com/bazel-ios/rules_ios/pull/199/files

segiddins
segiddins approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@segiddins segiddins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add a test that covers this, but not a blocker

ob
ob approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@ob ob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@amberdixon amberdixon merged commit b439882 into master Mar 30, 2021
@amberdixon amberdixon deleted the amber/missing-defines branch March 30, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob ob ob approved these changes

@segiddins segiddins segiddins approved these changes

@jerrymarino jerrymarino Awaiting requested review from jerrymarino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amberdixon @ob @segiddins