When not keeping edges, don't attempt to find the origin of an unexpe…

…cted exception in `SkyframeErrorProcessor`.

Currently, builds without edges will crash if there's an unexpected exception.

PiperOrigin-RevId: 557521507
Change-Id: Ia68525c8d3c0d1a8dbdcbe1ad3aebab2bd042c18

src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java

@@ -430,6 +430,7 @@ public SkyframeAnalysisResult configureTargets(
             skyframeExecutor.getCyclesReporter(),
             eventHandler,
             keepGoing,
+            skyframeExecutor.tracksStateForIncrementality(),
             eventBus,
             bugReporter);
 
@@ -712,9 +713,10 @@ public SkyframeAnalysisResult analyzeAndExecuteTargets(
                           skyframeExecutor.getCyclesReporter(),
                           eventHandler,
                           keepGoing,
+                          skyframeExecutor.tracksStateForIncrementality(),
                           eventBus,
                           bugReporter,
-                          /*includeExecutionPhase=*/ true)
+                          /* includeExecutionPhase= */ true)
                       .executionDetailedExitCode());
             }
           }
@@ -737,6 +739,7 @@ public SkyframeAnalysisResult analyzeAndExecuteTargets(
                       skyframeExecutor.getCyclesReporter(),
                       eventHandler,
                       keepGoing,
+                      skyframeExecutor.tracksStateForIncrementality(),
                       eventBus,
                       bugReporter,
                       /* includeExecutionPhase= */ true)
@@ -781,9 +784,10 @@ public SkyframeAnalysisResult analyzeAndExecuteTargets(
               skyframeExecutor.getCyclesReporter(),
               eventHandler,
               keepGoing,
+              skyframeExecutor.tracksStateForIncrementality(),
               eventBus,
               bugReporter,
-              /*includeExecutionPhase=*/ true);
+              /* includeExecutionPhase= */ true);
       detailedExitCodes.add(errorProcessingResult.executionDetailedExitCode());
 
       foundActionConflictInLatestCheck = !errorProcessingResult.actionConflicts().isEmpty();

src/main/java/com/google/devtools/build/lib/skyframe/SkyframeErrorProcessor.java

@@ -185,6 +185,7 @@ static ErrorProcessingResult processAnalysisErrors(
       CyclesReporter cyclesReporter,
       ExtendedEventHandler eventHandler,
       boolean keepGoing,
+      boolean keepEdges,
       @Nullable EventBus eventBus,
       BugReporter bugReporter)
       throws InterruptedException, ViewCreationFailedException {
@@ -194,9 +195,10 @@ static ErrorProcessingResult processAnalysisErrors(
           cyclesReporter,
           eventHandler,
           keepGoing,
+          keepEdges,
           eventBus,
           bugReporter,
-          /*includeExecutionPhase=*/ false);
+          /* includeExecutionPhase= */ false);
     } catch (BuildFailedException | TestExecException unexpected) {
       throw new IllegalStateException("Unexpected execution phase exception: ", unexpected);
     }
@@ -232,10 +234,13 @@ static ErrorProcessingResult processErrors(
       CyclesReporter cyclesReporter,
       ExtendedEventHandler eventHandler,
       boolean keepGoing,
+      boolean keepEdges,
       @Nullable EventBus eventBus,
       @Nullable BugReporter bugReporter,
       boolean includeExecutionPhase)
-      throws InterruptedException, ViewCreationFailedException, BuildFailedException,
+      throws InterruptedException,
+          ViewCreationFailedException,
+          BuildFailedException,
           TestExecException {
     boolean inBuildViewTest = eventBus == null;
     ViewCreationFailedException noKeepGoingAnalysisExceptionAspect = null;
@@ -260,9 +265,10 @@ static ErrorProcessingResult processErrors(
 
       SkyKey errorKey = getEffectiveErrorKey(errorEntry);
       if (includeExecutionPhase) {
-        assertValidAnalysisOrExecutionException(errorInfo, errorKey, result.getWalkableGraph());
+        assertValidAnalysisOrExecutionException(
+            errorInfo, errorKey, result.getWalkableGraph(), keepEdges);
       } else {
-        assertValidAnalysisException(errorInfo, errorKey, result.getWalkableGraph());
+        assertValidAnalysisException(errorInfo, errorKey, result.getWalkableGraph(), keepEdges);
       }
       Exception cause = errorInfo.getException();
       Preconditions.checkState(cause != null || !errorInfo.getCycleInfo().isEmpty(), errorInfo);
@@ -663,7 +669,8 @@ private static Label maybeGetConfiguredTargetCycleCulprit(
   }
 
   private static void assertValidAnalysisException(
-      ErrorInfo errorInfo, SkyKey key, WalkableGraph walkableGraph) throws InterruptedException {
+      ErrorInfo errorInfo, SkyKey key, WalkableGraph walkableGraph, boolean keepEdges)
+      throws InterruptedException {
     Throwable cause = errorInfo.getException();
     if (cause == null) {
       // Cycle.
@@ -675,11 +682,12 @@ private static void assertValidAnalysisException(
       return;
     }
 
-    logUnexpectedExceptionOrigin(errorInfo, key, walkableGraph, cause);
+    logUnexpectedExceptionOrigin(errorInfo, key, walkableGraph, cause, keepEdges);
   }
 
   private static void assertValidAnalysisOrExecutionException(
-      ErrorInfo errorInfo, SkyKey key, WalkableGraph walkableGraph) throws InterruptedException {
+      ErrorInfo errorInfo, SkyKey key, WalkableGraph walkableGraph, boolean keepEdges)
+      throws InterruptedException {
     Throwable cause = errorInfo.getException();
     if (cause == null) {
       // Cycle.
@@ -693,16 +701,25 @@ private static void assertValidAnalysisOrExecutionException(
       return;
     }
 
-    logUnexpectedExceptionOrigin(errorInfo, key, walkableGraph, cause);
+    logUnexpectedExceptionOrigin(errorInfo, key, walkableGraph, cause, keepEdges);
   }
 
   /**
    * Walk the graph to find a path to the lowest-level node that threw unexpected exception and log
    * it.
    */
   private static void logUnexpectedExceptionOrigin(
-      ErrorInfo errorInfo, SkyKey key, WalkableGraph walkableGraph, Throwable cause)
+      ErrorInfo errorInfo,
+      SkyKey key,
+      WalkableGraph walkableGraph,
+      Throwable cause,
+      boolean keepEdges)
       throws InterruptedException {
+    if (!keepEdges) {
+      // Can't traverse the graph to find the origin.
+      logUnexpectedException(key, errorInfo, "direct deps not stored");
+      return;
+    }
     List<SkyKey> path = new ArrayList<>();
     try {
       SkyKey currentKey = key;
@@ -728,10 +745,14 @@ private static void logUnexpectedExceptionOrigin(
         }
       } while (foundDep);
     } finally {
-      BugReport.logUnexpected("Unexpected analysis error: %s -> %s, (%s)", key, errorInfo, path);
+      logUnexpectedException(key, errorInfo, path);
     }
   }
 
+  private static void logUnexpectedException(SkyKey key, ErrorInfo errorInfo, Object extraInfo) {
+    BugReport.logUnexpected("Unexpected analysis error: %s -> %s, (%s)", key, errorInfo, extraInfo);
+  }
+
   @Nullable
   private static DetailedException convertToAnalysisException(Throwable cause) {
     // The cause may be NoSuch{Target,Package}Exception if we run the reduced loading phase and then

src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java

@@ -3835,6 +3835,7 @@ public void acceptConfiguredTargetAndDataError(NoSuchThingException error) {}
                 cyclesReporter,
                 eventHandler,
                 /* keepGoing= */ true,
+                tracksStateForIncrementality(),
                 /* eventBus= */ null,
                 bugReporter);
       } catch (ViewCreationFailedException ignored) {

src/test/java/com/google/devtools/build/lib/skyframe/SkyframeErrorProcessorTest.java

@@ -68,11 +68,12 @@ public void testProcessErrors_analysisErrorNoKeepGoing_throwsException(
             () ->
                 SkyframeErrorProcessor.processErrors(
                     result,
-                    /*cyclesReporter=*/ new CyclesReporter(),
-                    /*eventHandler=*/ mock(ExtendedEventHandler.class),
-                    /*keepGoing=*/ false,
-                    /*eventBus=*/ null,
-                    /*bugReporter=*/ null,
+                    /* cyclesReporter= */ new CyclesReporter(),
+                    /* eventHandler= */ mock(ExtendedEventHandler.class),
+                    /* keepGoing= */ false,
+                    /* keepEdges= */ true,
+                    /* eventBus= */ null,
+                    /* bugReporter= */ null,
                     includeExecutionPhase));
     assertThat(thrown).hasCauseThat().isEqualTo(analysisException);
   }