Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLVM 19 #392

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Add LLVM 19 #392

merged 1 commit into from
Sep 22, 2024

Conversation

mering
Copy link
Contributor

@mering mering commented Sep 19, 2024

The filenames changed significantly, so I had to add new logic. On the other hand, the file names are much easier to construct now, especially on Linux where there are no longer distro-specific variants as non-hermetic dynamic library dependencies like libtinfo5 have been removed.

@zaucy
Copy link
Contributor

zaucy commented Sep 21, 2024

there are no longer distro-specific variants

Glad to hear it! I tried out your branch on my projects and it works great.

#345 should be unnecessary if this gets merged

Copy link
Member

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new scheme is so much nicer!

@fmeum fmeum merged commit cd138e1 into bazel-contrib:master Sep 22, 2024
35 checks passed
@mering mering deleted the llvm-19 branch September 23, 2024 10:08
@mering
Copy link
Contributor Author

mering commented Sep 23, 2024

@fmeum For when is the next release including this PR planned?

@fmeum
Copy link
Member

fmeum commented Oct 3, 2024

@mering I cut a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants