Fix double slashes for sysroot = / #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
commented
Apr 10, 2024
fmeum
approved these changes
Apr 10, 2024
Ideally we could set the paths to `%sysroot%include` when we know that `%sysroot%` ends with `/`, but bazel validates that the prefix is actually `%sysroot%/` so we have to keep the extra slash.
fmeum
force-pushed
the
ks/fix-double-slashes-for-sysroot
branch
from
6b625cb to
b50a224
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we could set the paths to
%sysroot%includewhen we know that%sysroot%ends with/, but bazel validates that the prefix isactually
%sysroot%/so we have to keep the extra slash.