Update remaining deps #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
reviewed
Mar 12, 2024
| bazel_dep(name = "bazel_skylib", version = "1.4.2") | ||
| bazel_dep(name = "rules_cc", version = "0.0.8") | ||
| bazel_dep(name = "platforms", version = "0.0.7") | ||
| bazel_dep(name = "bazel_skylib", version = "1.5.0") |
There was a problem hiding this comment.
Since Bzlmod uses MVS, it's generally better to not update dependencies, unless of course we require a bug fix or new version. Users can do so painlessly if needed and otherwise enjoy greater freedom in choosing the versions that work for them.
There was a problem hiding this comment.
Understood. Do you want me to roll back? These deps should be harmless though.
I can certainly add this comment here, and mention that version updates are needed only for tests/MODULE.bazel.
There was a problem hiding this comment.
This is totally fine, no reason to roll back. I just wanted to point out the general situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.