Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make system module map generation faster and fully hermetic #280

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Make system module map generation faster and fully hermetic #280

merged 1 commit into from
Mar 14, 2024

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Mar 3, 2024 •
edited
Loading

  • system_module_maps no longer performs any IO.
  • The generated module map no longer references any non-hermetic paths and can thus be cached remotely, even when toolchain or sysroot are provided as absolute paths.

@fmeum fmeum force-pushed the improved-module-map branch 5 times, most recently from 3b4d52b to f2ee72f Compare March 4, 2024 11:02
fmeum
fmeum commented Mar 4, 2024
View reviewed changes
toolchain/toolchains.bzl.tpl Outdated Show resolved Hide resolved
@fmeum fmeum marked this pull request as ready for review March 4, 2024 11:56
siddharthab
siddharthab approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@siddharthab siddharthab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please land whenever you are ready. Let's make a release when this lands.

toolchain/internal/system_module_map.bzl Outdated Show resolved Hide resolved
toolchain/toolchains.bzl.tpl Outdated Show resolved Hide resolved
@siddharthab siddharthab mentioned this pull request Mar 13, 2024
Closed
@fmeum fmeum enabled auto-merge (squash) March 14, 2024 10:21
@fmeum fmeum merged commit 81f85c0 into bazel-contrib:master Mar 14, 2024
35 checks passed
@fmeum fmeum deleted the improved-module-map branch March 14, 2024 10:23
@jsharpe jsharpe mentioned this pull request Jun 5, 2024
Closed
jsharpe added a commit to jsharpe/bazel-toolchain that referenced this pull request Jun 5, 2024
@jsharpe
Revert "Make system module map generation faster and fully hermetic (b…
f718a13 
…azel-contrib#280)"

This reverts commit 81f85c0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthab siddharthab siddharthab approved these changes

@rrbutani rrbutani Awaiting requested review from rrbutani rrbutani is a code owner

@jsharpe jsharpe Awaiting requested review from jsharpe jsharpe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmeum @siddharthab