Move minimum supported version to Bazel 7.0.0 #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Note that I removed I would add this flag to llvm but it's a bit more work that I really wanted to put into it since the difference isn't really important |
|
Thanks @keith. I will merge this when our minimum supported version becomes 6.4.0. |
Closed
|
Could we maybe add a check for the Bazel version and merge this fix? Thanks 😄 |
|
bump. this is affecting us too. |
aran
reviewed
Feb 23, 2024
siddharthab
force-pushed
the
libtool
branch
2 times, most recently
from
1c6e45c
to
f570530
Compare
This removes the need to provide `--features=-libtool` on macOS.
siddharthab
changed the title
siddharthab
changed the title
helly25
added a commit
to helly25/mbo
that referenced
this pull request
Mar 25, 2024
* Drop `-fuse-ld=lld`. * Pin `toolchains_llvm` to bazel-contrib/toolchains_llvm#229. * Manually specify clang 17.0.6 files (required by the above).
helly25
added a commit
to helly25/mbo
that referenced
this pull request
Mar 25, 2024
* Add LLVM/Clang via foreign_rules at version 17.0.6. * Fix clang-format detection for the external repo. * Support version 19 in auto-detection. * No bzlmod. * Add foreign_rules_cc. * Add 3rd config to CI (GCC). * Show clang-format binary on failure * Working combination: * Drop `-fuse-ld=lld`. * Pin `toolchains_llvm` to bazel-contrib/toolchains_llvm#229. * Manually specify clang 17.0.6 files (required by the above).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need to provide flags like:
--incompatible_enable_cc_toolchain_resolution--features=-libtoolon macOS.--features=-supports_dynamic_linkeron macOS.As part of the update, test dep versions have also been updated.