Create an interface for executing Bazel commands #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
approved these changes
Jul 4, 2022
pkg/bazel.go
Outdated
|
|
||
| type BazelCmdConfig struct { | ||
| // Dir represents the working directory to use for the command. | ||
| // If Dir is the empty string, use the calling process' current directory. |
There was a problem hiding this comment.
Suggested change
| // If Dir is the empty string, use the calling process' current directory. | |
| // If Dir is the empty string, use the calling process's current directory. |
pkg/bazel.go
Outdated
| } | ||
|
|
||
| type BazelCmd interface { | ||
| Run(config BazelCmdConfig, args ...string) (int, error) |
There was a problem hiding this comment.
Possibly I'm being overly cautious here, but how would you feel about naming this Exec or Execute instead of Run? I can imagine reading bazel.Run as if it does a bazel run (and having BazelCmd.{Build,Test,Run}(...) rather than BazelCmd.Execute("build", ...) would be a completely reasonable alternate API choice)
There was a problem hiding this comment.
Good point, I'll change that.
pkg/bazel.go
Outdated
Comment on lines
35
to
41
| switch err.(type) { | ||
| case *exec.ExitError: | ||
| exitError, _ := err.(*exec.ExitError) | ||
| return exitError.ExitCode(), err | ||
| default: | ||
| return -1, err | ||
| } |
There was a problem hiding this comment.
Suggested change
| switch err.(type) { | |
| case *exec.ExitError: | |
| exitError, _ := err.(*exec.ExitError) | |
| return exitError.ExitCode(), err | |
| default: | |
| return -1, err | |
| } | |
| if exitError, ok := err.(*exec.ExitError); ok { | |
| return exitError.ExitCode(), err | |
| } else { | |
| return -1, err | |
| } |
|
Addressed comments |
This makes it easier to plug the Target Determinator into larger applications that already have tight control over how Bazel is executed (eg. when using this as a plugin of Aspect's CLI tool).
sitaktif
force-pushed
the
bazel-cmd-interface
branch
from
03f7af5
to
855ee0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to plug the Target Determinator into larger
applications that already have tight control over how Bazel is executed
(eg. when using this as a plugin of Aspect's CLI tool).