Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve string for "current working dir state" #13

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Improve string for "current working dir state" #13

merged 1 commit into from
Jun 28, 2022

Conversation

sitaktif
Copy link
Collaborator

Before this change, upon errors, target-determinator would display e.g.:

failed to load metadata at  (sha: )

Now, it will display:

failed to load metadata at revision 'after' (current working directory state)

@sitaktif
Improve string for "current working dir state"
b4a1e5e 
Before this change, upon errors, target-determinator would display e.g.:

```
failed to load metadata at  (sha: )
```

Now, it will display:

```
failed to load metadata at revision 'after' (current working directory state)
```
illicitonion
illicitonion approved these changes Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illicitonion illicitonion merged commit 2dace28 into bazel-contrib:main Jun 28, 2022
@sitaktif sitaktif deleted the current-rev-display branch June 28, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sitaktif @illicitonion