Import target determinator and test suite #1
Conversation
| /bazel-* | ||
| /.ijwb/ | ||
|
|
||
| /third_party/protobuf/bazel/*/*.pb.go |
There was a problem hiding this comment.
if these files are needed to make the editor happy, you could check them in
There was a problem hiding this comment.
They're not required, it's more of a "If you wanted to see the output" - IntelliJ works fine for me without the manual generation.
| Author: Daniel Wagner-Hall <dwagnerhall@apple.com> | ||
| Date: Thu Apr 21 18:21:46 2022 +0100 | ||
|
|
||
| Only return rules (and not external ones) |
There was a problem hiding this comment.
is there an upstream PR for it yet? Ideally that PR number would go in the filename of this patch, so it's easier for us to track when it's merged and the patch can be dropped.
There was a problem hiding this comment.
There is not - I'll happily kick off a discussion async :)
There was a problem hiding this comment.
sounds good, I often just create the draft PR at least as a placeholder so I don't forget to start the process of converging again with upstream
| import java.util.Set; | ||
| import org.junit.Ignore; | ||
|
|
||
| public class BazelDiffIntegrationTest extends Tests { |
There was a problem hiding this comment.
could you add a README explaining whether this is testing against all three implementations?
There was a problem hiding this comment.
Added in 08765c6 :)
I wasn't intending for there to be - should there be? |
| @@ -0,0 +1,138 @@ | |||
| # This file was manually copied from https://github.com/ewhauser/bazel-differ/blob/916e6409ae501c56ac4d6da9c0785c2ee97721b3/deps.bzl because gazelle doesn't seem to like working with dep files from remote repositories. | |||
There was a problem hiding this comment.
I've had this issue recently as well, was it related to select clauses in generated BUILD files?
aspect-build/bazel-examples#4 (comment)
One of us should file upstream on gazelle...
|
oh and we should figure out why the tests aren't triggering on this PR |
| name: presubmit | ||
| on: | ||
| push: | ||
| pull_request: |
There was a problem hiding this comment.
I think this empty block is the problem with no checks running
I think GitHub Actions can't be added in a PR from another fork, or something like that. They've been running on my fork: https://github.com/illicitonion/target-determinator/runs/6323004650?check_suite_focus=true and I expect them to start running on merge :) |
No description provided.