build(builtin): cleanup //internal/npm_install/test:test

[gregmagolan]

Fixes local development issue on Windows where this test would fail on 2nd run due BUILD to files left on disk by the build file generator. Since Windows has no runfiles, the build file generator was running in the sources folder.

Also removes another package.json from node_repositories :)

[gregmagolan]

For reference, the Windows failure when you run //internal/npm_install/test:test is

==================== Test output for //internal/npm_install/test:test:
Randomized with seed 07572
Started
FFFFFFFFFFFFFFFFFFFFFFF...........

Failures:
1) build file generator integration test should produce a BUILD file for node_modules/@angular/core/BUILD.bazel
  Message:
    Error: ENOENT: no such file or directory, open 'C:\users\gmago\google\rules_nodejs\internal\npm_install\test/package/node_modules/@angular/core/BUILD.bazel'
  Stack:
    error properties: Object({ errno: -4058, syscall: 'open', code: 'ENOENT', path: 'C:\users\gmago\google\rules_nodejs\internal\npm_install\test/package/node_modules/@angular/core/BUILD.bazel' })
    Error: ENOENT: no such file or directory, open 'C:\users\gmago\google\rules_nodejs\internal\npm_install\test/package/node_modules/@angular/core/BUILD.bazel'
        at Object.openSync (fs.js:436:3)
        at Object.readFileSync (fs.js:341:35)
        at check (C:\users\gmago\google\rules_nodejs\internal\npm_install\test\check.js:20:10)
        at UserContext.it (C:\users\gmago\google\rules_nodejs\internal\npm_install\test\generate_build_file.spec.js:9:9)
        at <Jasmine>
        at runCallback (timers.js:705:18)
        at tryOnImmediate (timers.js:676:5)
        at processImmediate (timers.js:658:5)

2) build file generator integration test should produce a BUILD file for node_modules/zone.js/BUILD.bazel
  Message:
    Error: ENOENT: no such file or directory, open 'C:\users\gmago\google\rules_nodejs\internal\npm_install\test/package/node_modules/zone.js/BUILD.bazel'
  Stack:
    error properties: Object({ errno: -4058, syscall: 'open', code: 'ENOENT', path: 'C:\users\gmago\google\rules_nodejs\internal\npm_install\test/package/node_modules/zone.js/BUILD.bazel' })
    Error: ENOENT: no such file or directory, open 'C:\users\gmago\google\rules_nodejs\internal\npm_install\test/package/node_modules/zone.js/BUILD.bazel'
        at Object.openSync (fs.js:436:3)
        at Object.readFileSync (fs.js:341:35)
        at check (C:\users\gmago\google\rules_nodejs\internal\npm_install\test\check.js:20:10)
        at UserContext.it (C:\users\gmago\google\rules_nodejs\internal\npm_install\test\generate_build_file.spec.js:9:9)
        at <Jasmine>
        at runCallback (timers.js:705:18)
        at tryOnImmediate (timers.js:676:5)
        at processImmediate (timers.js:658:5)

3) build file generator integration test should produce a BUILD file for zone.js/BUILD.bazel
  Message:
    Error: ENOENT: no such file or directory, open 'C:\users\gmago\google\rules_nodejs\internal\npm_install\test/package/zone.js/BUILD.bazel'
  Stack:
    error properties: Object({ errno: -4058, syscall: 'open', code: 'ENOENT', path: 'C:\users\gmago\google\rules_nodejs\internal\npm_install\test/package/zone.js/BUILD.bazel' })
    Error: ENOENT: no such file or directory, open 'C:\users\gmago\google\rules_nodejs\internal\npm_install\test/package/zone.js/BUILD.bazel'
        at Object.openSync (fs.js:436:3)
        at Object.readFileSync (fs.js:341:35)
        at check (C:\users\gmago\google\rules_nodejs\internal\npm_install\test\check.js:20:10)
        at UserContext.it (C:\users\gmago\google\rules_nodejs\internal\npm_install\test\generate_build_file.spec.js:9:9)
        at <Jasmine>
        at ontimeout (timers.js:436:11)
        at tryOnTimeout (timers.js:300:5)
        at listOnTimeout (timers.js:263:5)
        at Timer.processTimers (timers.js:223:10)
...
21) build file generator integration test should produce a BUILD file for @gregmagolan/test-b/bin/BUILD.bazel
  Message:
    Error: ENOENT: no such file or directory, open 'C:\users\gmago\google\rules_nodejs\internal\npm_install\test/package/@gregmagolan/test-b/bin/BUILD.bazel'
  Stack:
    error properties: Object({ errno: -4058, syscall: 'open', code: 'ENOENT', path: 'C:\users\gmago\google\rules_nodejs\internal\npm_install\test/package/@gregmagolan/test-b/bin/BUILD.bazel' })
    Error: ENOENT: no such file or directory, open 'C:\users\gmago\google\rules_nodejs\internal\npm_install\test/package/@gregmagolan/test-b/bin/BUILD.bazel'
        at Object.openSync (fs.js:436:3)
        at Object.readFileSync (fs.js:341:35)
        at check (C:\users\gmago\google\rules_nodejs\internal\npm_install\test\check.js:20:10)
        at UserContext.it (C:\users\gmago\google\rules_nodejs\internal\npm_install\test\generate_build_file.spec.js:9:9)
        at <Jasmine>
        at runCallback (timers.js:705:18)
        at tryOnImmediate (timers.js:676:5)
        at processImmediate (timers.js:658:5)

22) build file generator integration test should produce a BUILD file for @gregmagolan/test-b/BUILD.bazel
  Message:
    Error: ENOENT: no such file or directory, open 'C:\users\gmago\google\rules_nodejs\internal\npm_install\test/package/@gregmagolan/test-b/BUILD.bazel'
  Stack:
    error properties: Object({ errno: -4058, syscall: 'open', code: 'ENOENT', path: 'C:\users\gmago\google\rules_nodejs\internal\npm_install\test/package/@gregmagolan/test-b/BUILD.bazel' })
    Error: ENOENT: no such file or directory, open 'C:\users\gmago\google\rules_nodejs\internal\npm_install\test/package/@gregmagolan/test-b/BUILD.bazel'
        at Object.openSync (fs.js:436:3)
        at Object.readFileSync (fs.js:341:35)
        at check (C:\users\gmago\google\rules_nodejs\internal\npm_install\test\check.js:20:10)
        at UserContext.it (C:\users\gmago\google\rules_nodejs\internal\npm_install\test\generate_build_file.spec.js:9:9)
        at <Jasmine>
        at runCallback (timers.js:705:18)
        at tryOnImmediate (timers.js:676:5)
        at processImmediate (timers.js:658:5)

23) build file generator integration test should produce a BUILD file for ajv/BUILD.bazel
  Message:
    Error: ENOENT: no such file or directory, open 'C:\users\gmago\google\rules_nodejs\internal\npm_install\test/package/ajv/BUILD.bazel'
  Stack:
    error properties: Object({ errno: -4058, syscall: 'open', code: 'ENOENT', path: 'C:\users\gmago\google\rules_nodejs\internal\npm_install\test/package/ajv/BUILD.bazel' })
    Error: ENOENT: no such file or directory, open 'C:\users\gmago\google\rules_nodejs\internal\npm_install\test/package/ajv/BUILD.bazel'
        at Object.openSync (fs.js:436:3)
        at Object.readFileSync (fs.js:341:35)
        at check (C:\users\gmago\google\rules_nodejs\internal\npm_install\test\check.js:20:10)
        at UserContext.it (C:\users\gmago\google\rules_nodejs\internal\npm_install\test\generate_build_file.spec.js:9:9)
        at <Jasmine>
        at ontimeout (timers.js:436:11)
        at tryOnTimeout (timers.js:300:5)
        at listOnTimeout (timers.js:263:5)
        at Timer.processTimers (timers.js:223:10)

[alexeagle]

I don't really understand what this test is doing internally, but this is simpler so I ❤️