fix(esbuild): provide JSModuleInfo of output bundle #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
requested review from
alexeagle,
gregmagolan,
mattem and
soldair
as code owners
|
Seems good to me, even with a test I'm not sure exactly what we'd be testing, as at this point handling providers is bazel internal, there is no starlark logic here and we have existing tests to verify the right output. |
mattem
approved these changes
May 20, 2021
|
I think a test would need to confirm that the provider interacts with another rule consuming the provider and make sure the integrate properly. However most rules consuming this provider fallback to the default info anyway so the tests would probably pass either way >_> I still think it's worth the consistency with rollup+terser etc 🤷 |
alexeagle
pushed a commit
that referenced
this pull request
May 26, 2021
twheys
pushed a commit
to twheys/rules_nodejs
that referenced
this pull request
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like other rules such as rollup and terser provide this, and it makes sense. I'm not sure of the greatest way to test it though? All 3 could probably use such a test...