refactor: make our full set of typings mutually compatible #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
force-pushed
the
types_simpler
branch
2 times, most recently
from
0c7178f
to
36ce39d
Compare
By not installing @types/jest and @types/jasmine together, we avoid TS having type conflicts when running outside the sandbox. This makes it a lot easier to make compiles succeed on windows for example, which trips a lot of first-time contributors
alexeagle
force-pushed
the
types_simpler
branch
from
36ce39d
to
e7551df
Compare
mattem
approved these changes
Apr 21, 2021
twheys
pushed a commit
to twheys/rules_nodejs
that referenced
this pull request
Jan 13, 2022
…trib#2617) By not installing @types/jest and @types/jasmine together, we avoid TS having type conflicts when running outside the sandbox. This makes it a lot easier to make compiles succeed on windows for example, which trips a lot of first-time contributors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not installing @types/jest and @types/jasmine together, we avoid TS having type conflicts when running outside the sandbox.
This makes it a lot easier to make compiles succeed on windows for example, which trips a lot of first-time contributors