Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): handle .tsx inputs to angular #2613

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

alexeagle
Copy link
Collaborator

Fixes #2542

@mattem
Copy link
Collaborator

mattem commented Apr 19, 2021

I guess there's no existing test coverage here?

@alexeagle
Copy link
Collaborator Author

I considered adding a .tsx file to one of our examples, which is where the obvious coverage is. But that's probably too confusing for users to come across, given the small value in adding an assertion here.
Alternately we could add some new smaller test fixture here in packages/typescript but I'm not really inclined to put much effort into ts_library since we think it's not a good long-term design.

@alexeagle alexeagle merged commit 901df38 into bazel-contrib:stable Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ts_library with use_angular_plugin doesn't correctly build TSX files
2 participants