Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): remove relativeLinkResolution #2530

Merged
merged 1 commit into from
Mar 14, 2021

Conversation

saxicek
Copy link
Contributor

@saxicek saxicek commented Mar 14, 2021

Relative routing is not used in the angular_bazel_architect example.
Parameter relativeLinkResolution introduced by Angular migration is
not required.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

PR for change as asked in #2495 (comment)

Relative routing is not used in the angular_bazel_architect example.
Parameter `relativeLinkResolution` introduced by Angular migration is
not required.
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@mattem mattem merged commit 8ef60e5 into bazel-contrib:stable Mar 14, 2021
@saxicek saxicek deleted the remove-link-resolution branch March 16, 2021 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants