Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esbuild): add --preserve-symlinks flag by default and npm module mappings #2477

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

mattem
Copy link
Collaborator

@mattem mattem commented Feb 18, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

It was possible for esbuild to break out of the sandbox and find the .ts file inputs, this could be seen if the .ts file was generated, as it would live in bazel-out/

This also fixes an issue where external npm modules may not have gotten resolved correctly when bundling

Issue Number: N/A

What is the new behavior?

Bumps the tested version of esbuild and adds the --preserve-symlinks flag by default.

Does this PR introduce a breaking change?

  • Yes
  • No
  • kinda

This will require uses to bump the version of esbuild used in their projects

@google-cla google-cla bot added the cla: yes label Feb 18, 2021
@mattem mattem changed the title fix(esbuild): add --preserve-symlinks flag by default fix(esbuild): add --preserve-symlinks flag by default and npm module mappings Feb 18, 2021
@mattem mattem marked this pull request as ready for review February 18, 2021 16:27
commitlint.config.js Outdated Show resolved Hide resolved
@alexeagle alexeagle merged commit eb71285 into bazel-contrib:stable Feb 19, 2021
@mattem mattem deleted the feat/resolve_extensions branch March 4, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants