fix(examples): fix angular examples prod serve doesn't work on windows #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
requested review from
alexeagle,
gregmagolan and
soldair
as code owners
alan-agius4
force-pushed
the
history-server-windows
branch
from
48ac536
to
a0b84f0
Compare
In Windows runfiles are not always available thus we need to use the real location using `rlocation`. Closes bazel-contrib#1606
alan-agius4
force-pushed
the
history-server-windows
branch
from
a0b84f0
to
e1b0e94
Compare
matsko
pushed a commit
to angular/angular
that referenced
this pull request
Mar 11, 2020
In Windows runfiles are not always available thus we need to use the real location using rlocation. Related to bazel-contrib/rules_nodejs#1699 PR Close #35991
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Windows runfiles are not always available thus we need to use the real location using
rlocation.Closes #1606