Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(builtin): don't include external files when pkg_npm is in root pa… #1677

Merged
merged 1 commit into from
Mar 2, 2020
Merged

fix(builtin): don't include external files when pkg_npm is in root pa… #1677

merged 1 commit into from
Mar 2, 2020

Commits on Feb 28, 2020

  1. fix(builtin): don't include external files when pkg_npm is in root pa… 

    …ckage

This logic assumed that package_path was non-empty, but when a pkg_npm rule appears in the workspace root, package_path will be empty string and the startswith guard has no effect.

Fixes bazel-contrib#1499
    @alexeagle
    alexeagle committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    30a5fc6 View commit details
    Browse the repository at this point in the history