fix: html script injection is broken on windows #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
requested review from
alexeagle,
gregmagolan and
soldair
as code owners
jbedard
approved these changes
Feb 5, 2020
alan-agius4
force-pushed
the
html-insert-assets-win
branch
from
c3d9d69
to
b431da1
Compare
`html-insert-assets` version `0.5.0` in includes the following fix: jbedard/html-insert-assets#6 which is needed for better Windows support. Closes bazel-contrib#1604
alan-agius4
force-pushed
the
html-insert-assets-win
branch
from
b431da1
to
f712253
Compare
alexeagle
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
html-insert-assetsversion0.5.0includes the following fix: jbedard/html-insert-assets#6 which is needed for better Windows support.Closes #1604