fix: invalidate installed npm repositories correctly (#1200) #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredNeil
requested review from
alexeagle,
gregmagolan and
soldair
as code owners
JaredNeil
commented
Sep 27, 2019
|
|
||
| bzlFile += `def install_${workspace}(): | ||
| _maybe( | ||
| copy_repository, | ||
| name = "${workspace}", | ||
| marker_file = "@${WORKSPACE}//_workspaces/${workspace}:_bazel_workspace_marker", | ||
| # Ensure that changes to the node_modules cause the copy to re-execute |
There was a problem hiding this comment.
Apparently this doesn't actually work, so we need to force it by including the hash of the lock file.
gregmagolan
requested changes
Oct 1, 2019
There was a problem hiding this comment.
Thanks @JaredNeil. This looks like a good fix. I wonder if something has changed in Bazel as the lock_file attribute worked 7 months ago when @alexeagle added it to fix the same issue.
Can you rebase to head? This will fix the examples/worker CI failure as it was missing the yarn.lock file which is now checked in.
Can you also remove the now unused lock_file attribute in internal/copy_repository/copy_repository.bzl?
JaredNeil
force-pushed
the
jaredneil-fix-install
branch
from
c1f8d4c
to
4827723
Compare
|
Fixes #1200 |
|
Awesome thank you!! This was a nasty bug |
Toxicable
pushed a commit
to Toxicable/rules_nodejs
that referenced
this pull request
Oct 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1200
What is the new behavior?
Repository is always copied when lock file changes.
Does this PR introduce a breaking change?
Other information