Skip to content

Commit

Permalink
chore: update codeowners (#2004)
Browse files Browse the repository at this point in the history
Add Dan for cypress and Greg globally
  • Loading branch information
alexeagle authored Jul 6, 2020
1 parent 3bac870 commit d800c70
Show file tree
Hide file tree
Showing 7 changed files with 25 additions and 7 deletions.
1 change: 1 addition & 0 deletions .bazelignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ bazel-out
e2e/symlinked_node_modules_yarn/node_modules
e2e/symlinked_node_modules_npm/node_modules/
packages/angular/node_modules
examples/angular/node_modules
4 changes: 4 additions & 0 deletions .github/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,12 @@ generate_codeowners(
"//:OWNERS",
"//packages/labs:OWNERS",
"//packages/rollup:OWNERS",
"//packages/cypress:OWNERS",
"//packages/angular:OWNERS",
"//examples:OWNERS.examples_jest",
"//examples:OWNERS.examples_nestjs",
"//examples:OWNERS.examples_cypress",
"//examples:OWNERS.examples_angular",
"//examples:OWNERS.examples_protocol_buffers",
"//examples:OWNERS.examples_angular_bazel_architect",
],
Expand Down
16 changes: 10 additions & 6 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@
# yarn update-codeowners

* @mattem @gregmagolan @soldair @alexeagle
/packages/labs/** @mrmeku @alexeagle @mattem
/packages/rollup/** @jbedard @alexeagle @mattem
/packages/angular/** @alan-agius4 @alexeagle @mattem
/examples/nestjs/** @zachgrayio @zMotivat0r @rayman1104 @siberex @alexeagle @mattem
/examples/protocol_buffers/** @mrmeku @alexeagle @mattem
/examples/angular_bazel_architect/** @alan-agius4 @alexeagle @mattem
/packages/labs/** @mrmeku @alexeagle @gregmagolan @mattem
/packages/rollup/** @jbedard @alexeagle @gregmagolan @mattem
/packages/cypress/** @mrmeku @alexeagle @gregmagolan @mattem
/packages/angular/** @alan-agius4 @alexeagle @gregmagolan @mattem
/examples/jest/** @mrmeku @alexeagle @gregmagolan @mattem
/examples/nestjs/** @zachgrayio @zMotivat0r @rayman1104 @siberex @alexeagle @gregmagolan @mattem
/examples/cypress/** @mrmeku @alexeagle @gregmagolan @mattem
/examples/angular/** @alan-agius4 @alexeagle @gregmagolan @mattem
/examples/protocol_buffers/** @mrmeku @alexeagle @gregmagolan @mattem
/examples/angular_bazel_architect/** @alan-agius4 @alexeagle @gregmagolan @mattem
3 changes: 3 additions & 0 deletions examples/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ example_integration_test(
"//packages/terser:npm_package": "@bazel/terser",
"//packages/typescript:npm_package": "@bazel/typescript",
},
owners = ["@alan-agius4"],

# bazel-in-bazel examples_angular fails on Windows on bazelci cloning a git repo:
# ```
Expand Down Expand Up @@ -102,11 +103,13 @@ example_integration_test(
"//packages/cypress:npm_package": "@bazel/cypress",
"//packages/typescript:npm_package": "@bazel/typescript",
},
owners = ["@mrmeku"],
tags = ["cypress"],
)

example_integration_test(
name = "examples_jest",
owners = ["@mrmeku"],
)

example_integration_test(
Expand Down
6 changes: 5 additions & 1 deletion packages/cypress/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,16 @@
# limitations under the License.

load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
load("@build_bazel_rules_nodejs//:tools/defaults.bzl", "pkg_npm")
load("@build_bazel_rules_nodejs//:tools/defaults.bzl", "codeowners", "pkg_npm")
load("@build_bazel_rules_nodejs//tools/stardoc:index.bzl", "stardoc")
load("//third_party/github.com/bazelbuild/bazel-skylib:rules/copy_file.bzl", "copy_file")

package(default_visibility = ["//visibility:public"])

codeowners(
teams = ["@mrmeku"],
)

bzl_library(
name = "bzl",
srcs = glob(["**/*.bzl"]),
Expand Down
1 change: 1 addition & 0 deletions scripts/update_codeowners.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#!/usr/bin/env bash
# Update the owners=[] attribute in //.github:gen_codeowners
set -euo pipefail

BAZEL=./node_modules/.bin/bazel
BUILDOZER=./node_modules/.bin/buildozer
Expand Down
1 change: 1 addition & 0 deletions tools/defaults.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ def pkg_npm(**kwargs):

_GLOBAL_OWNERS = [
"@alexeagle",
"@gregmagolan",
"@mattem",
]

Expand Down

0 comments on commit d800c70

Please sign in to comment.