fix(docs): fix regex that replaces //packages with @bazel

It was producing wrong outputs that dropped one path segment.
Also add a better error if the terser_bin attribute is missing (when not in a repo named @npm)

docs/Concatjs.md

@@ -204,14 +204,14 @@ Defaults to `[]`
 
             Defaults to precompiled go binary setup by @bazel/typescript npm package
 
-Defaults to `@npm//@bazel/devserver:devserver`
+Defaults to `@npm//@bazel/concatjs/devserver:devserver`
 
 <h4 id="concatjs_devserver-devserver_host">devserver_host</h4>
 
 (*<a href="https://bazel.build/docs/build-ref.html#labels">Label</a>*): Go based devserver executable for the host platform.
             Defaults to precompiled go binary setup by @bazel/typescript npm package
 
-Defaults to `@npm//@bazel/devserver:devserver_darwin_amd64`
+Defaults to `@npm//@bazel/concatjs/devserver:devserver_darwin_amd64`
 
 <h4 id="concatjs_devserver-entry_module">entry_module</h4>
 

docs/Rollup.md

@@ -335,7 +335,7 @@ Defaults to `@npm//rollup/bin:rollup`
 
 (*<a href="https://bazel.build/docs/build-ref.html#labels">Label</a>*): Internal use only
 
-Defaults to `@npm//@bazel/bin:rollup-worker`
+Defaults to `@npm//@bazel/rollup/bin:rollup-worker`
 
 <h4 id="rollup_bundle-silent">silent</h4>
 

docs/Terser.md

@@ -144,6 +144,6 @@ If you want to do this, you can pass a filegroup here.
 
 (*<a href="https://bazel.build/docs/build-ref.html#labels">Label</a>*): An executable target that runs Terser
 
-Defaults to `@npm//@bazel/bin:terser`
+Defaults to `@npm//@bazel/terser/bin:terser`
 
 

packages/terser/index.js

@@ -165,8 +165,12 @@ function main() {
     // If necessary, get the new `terser` binary, added for >=4.3.0
     terserBinary = terserBinary || require.resolve('terser/bin/terser');
   } catch (e) {
-    // If necessary, get the old `uglifyjs` binary from <4.3.0
-    terserBinary = terserBinary || require.resolve('terser/bin/uglifyjs');
+    try {
+      // If necessary, get the old `uglifyjs` binary from <4.3.0
+      terserBinary = terserBinary || require.resolve('terser/bin/uglifyjs');
+    } catch (e) {
+      throw new Error('terser binary not found. Maybe you need to set the terser_bin attribute?')
+    }
   }
   // choose a default concurrency of the number of cores -1 but at least 1.
 
@@ -194,4 +198,4 @@ exports.directoryArgs = directoryArgs;
 
 if (require.main === module) {
   main();
-}
+}

tools/stardoc/post-process-docs.js

@@ -7,11 +7,10 @@ const content = readFileSync(md, {encoding: 'utf8'});
 // @npm is not the required name, but it seems to be the common case
 // this reflects the similar transformation made when publishing the packages to npm
 // via pkg_npm defined in //tools:defaults.bzl
-const out = content
-  .replace(/(?:@.*)*?\/\/packages\/([^:"\s]*)/g, (str, pkg) => {
-    const parts = pkg.split('/');
-    return `@npm//@bazel/${parts[parts.length - 1]}`;
-  });
+const out = content.replace(/(?:@.*)*?\/\/packages\/([^/:"\s]*)/g, (str, pkg) => {
+  const parts = pkg.split('/');
+  return `@npm//@bazel/${parts[parts.length - 1]}`;
+});
 
 // stamp the frontmatter into the post processed stardoc HTML
 const frontmatter = [