Skip to content

Commit

Permalink
Update examples/vendored_node to reflect best practice of specifying …
Browse files Browse the repository at this point in the history
…node version (#810)

The docs for node_repositories() reflect this now and the reason is that node_repositories() will set node options depending on version used
  • Loading branch information
gregmagolan authored May 31, 2019
1 parent 690c5bd commit b59e4cf
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions examples/vendored_node/WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ local_repository(
load("@build_bazel_rules_nodejs//:defs.bzl", "node_repositories", "npm_install", "yarn_install")

node_repositories(
node_version = "10.12.0",
vendored_node = "@examples_vendored_node//:node-v10.12.0-linux-x64",
vendored_yarn = "@examples_vendored_node//:yarn-v1.10.0",
)
Expand Down

0 comments on commit b59e4cf

Please sign in to comment.