Skip to content

Commit

Permalink
chore: turn off workers on RBE
Browse files Browse the repository at this point in the history
Maybe fixes our surprising build failure
  • Loading branch information
Alex Eagle committed Dec 10, 2020
1 parent 6bf8ae7 commit 546a89b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
1 change: 1 addition & 0 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,7 @@ tasks:
# TODO(gregmagolan): figure out how to install missing shared libs
# Without this filter the @cypress external repository will be built and that build will fail due to missing shared libs.
- "--build_tag_filters=-cypress,-pkg_npm.pack"
- "--define=NODE_DEBUG=module"
test_flags:
# TODO(gregmagolan): figure out how to install missing shared libs
- "--test_arg=-cypress"
12 changes: 10 additions & 2 deletions packages/labs/protobufjs/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ nodejs_binary(
"@build_bazel_rules_typescript_protobufs_compiletime_deps//estraverse",
],
entry_point = "@build_bazel_rules_typescript_protobufs_compiletime_deps//:node_modules/protobufjs/bin/pbjs",
templated_args = ["--nobazel_run_linker"],
# TODO: remove these flags, make this resolve dependencies via the linker
templated_args = [
"--bazel_patch_module_resolver",
"--nobazel_run_linker",
],
)

nodejs_binary(
Expand All @@ -66,7 +70,11 @@ nodejs_binary(
"@build_bazel_rules_typescript_protobufs_compiletime_deps//estraverse",
],
entry_point = "@build_bazel_rules_typescript_protobufs_compiletime_deps//:node_modules/protobufjs/bin/pbts",
templated_args = ["--nobazel_run_linker"],
# TODO: remove these flags, make this resolve dependencies via the linker
templated_args = [
"--bazel_patch_module_resolver",
"--nobazel_run_linker",
],
)

# Runtime libraries needed by the protobufjs library.
Expand Down

0 comments on commit 546a89b

Please sign in to comment.