Skip to content

Commit

Permalink
fix(builtin): pass though declarations from DeclarationInfo provider
Browse files Browse the repository at this point in the history
  • Loading branch information
mattem committed Mar 22, 2021
1 parent 8d0218c commit 4fed67f
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion internal/node/node.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ They support module mapping: any targets in the transitive dependencies with
a `module_name` attribute can be `require`d by that name.
"""

load("//:providers.bzl", "ExternalNpmPackageInfo", "JSModuleInfo", "JSNamedModuleInfo", "NodeRuntimeDepsInfo", "node_modules_aspect")
load("//:providers.bzl", "DeclarationInfo", "ExternalNpmPackageInfo", "JSModuleInfo", "JSNamedModuleInfo", "NodeRuntimeDepsInfo", "node_modules_aspect")
load("//internal/common:expand_into_runfiles.bzl", "expand_location_into_runfiles")
load("//internal/common:module_mappings.bzl", "module_mappings_runtime_aspect")
load("//internal/common:path_utils.bzl", "strip_external")
Expand Down Expand Up @@ -150,6 +150,8 @@ def _nodejs_binary_impl(ctx):
for d in ctx.attr.data:
if JSModuleInfo in d:
sources_depsets.append(d[JSModuleInfo].sources)
if DeclarationInfo in d:
sources_depsets.append(d[DeclarationInfo].declarations)

# Deprecated should be removed with version 3.x.x at least have a transition phase
# for dependencies to provide the output under the JSModuleInfo instead.
Expand Down

0 comments on commit 4fed67f

Please sign in to comment.