test: copy_to_bin shenanigans for Windows CI

bazel-contrib · Apr 29, 2020 · 3e13dbe · 3e13dbe
1 parent 199acf4
commit 3e13dbe
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 6 deletions.
diff --git a/internal/linker/test/issue_1823/BUILD.bazel b/internal/linker/test/issue_1823/BUILD.bazel
@@ -1,3 +1,4 @@
+load("@build_bazel_rules_nodejs//:index.bzl", "copy_to_bin")
 load("@npm_bazel_typescript//:index.bzl", "ts_library")
 load(":ts_jest_test.bzl", "ts_jest_test")
 
@@ -10,12 +11,19 @@ ts_library(
     ],
 )
 
+# Shenanigans for Windows which doesn't have runfiles symlinks
+# We need the jest config to be in the output tree where the specs are
+copy_to_bin(
+    name = "jest_config",
+    srcs = ["jest.config.js"],
+)
+
 ts_jest_test(
     name = "test",
     srcs = [
         "lib.test.ts",
     ],
-    jest_config = "jest.config.js",
+    jest_config = ":jest_config",
     deps = [
         ":lib",
     ],

diff --git a/internal/linker/test/issue_1823/ts_jest_test.bzl b/internal/linker/test/issue_1823/ts_jest_test.bzl
@@ -25,11 +25,11 @@ Uses ts_library devmode UMD output"""
         "--no-watchman",
         "--ci",
     ]
-    args.extend(["--config", "$(rootpath %s)" % jest_config])
+    args.extend(["--config", "$$(rlocation $(rootpath %s))" % jest_config])
 
     _jest_test(
         name = name,
         data = [jest_config, ":%s_umd" % name] + deps + data,
-        args = args,
+        templated_args = args,
         **kwargs
     )
diff --git a/internal/linker/test/issue_1823_use_ts_library_esm/BUILD.bazel b/internal/linker/test/issue_1823_use_ts_library_esm/BUILD.bazel
@@ -1,3 +1,4 @@
+load("@build_bazel_rules_nodejs//:index.bzl", "copy_to_bin")
 load("@npm_bazel_typescript//:index.bzl", "ts_library")
 load(":ts_jest_test.bzl", "ts_jest_test")
 
@@ -14,15 +15,33 @@ ts_library(
     ],
 )
 
+# Shenanigans for Windows which doesn't have runfiles symlinks
+# We need the jest config to be in the output tree where the specs are
+copy_to_bin(
+    name = "jest_config",
+    srcs = [
+        "jest.config.js",
+    ],
+)
+
+# Same goes for babelrc. We can't add it to the jest_config copy_to_bin
+# since must be a file that is passed to jest in the --config arg.
+copy_to_bin(
+    name = "babel_rc",
+    srcs = [
+        ".babelrc",
+    ],
+)
+
 ts_jest_test(
     name = "test",
     srcs = [
         "lib.test.ts",
     ],
     data = [
-        ".babelrc",
+        ":babel_rc",
     ],
-    jest_config = "jest.config.js",
+    jest_config = ":jest_config",
     deps = [
         ":lib",
         "@npm//@babel/preset-env",

diff --git a/internal/linker/test/issue_1823_use_ts_library_esm/ts_jest_test.bzl b/internal/linker/test/issue_1823_use_ts_library_esm/ts_jest_test.bzl
@@ -28,7 +28,7 @@ Uses ts_library prodmode ems output"""
         "--no-watchman",
         "--ci",
     ]
-    args.extend(["--config", "$(rootpath %s)" % jest_config])
+    args.extend(["--config", "$$(rlocation $(rootpath %s))" % jest_config])
 
     _jest_test(
         name = name,