Add preliminary support for exe packaging type
#908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
rdesgroppes
force-pushed
the
add-preliminary-support-for-exe-packaging-type
branch
3 times, most recently
from
e6052fb to
352ebaa
Compare
This is to allow fetching prebuilt binaries (such as [protoc](https://repo1.maven.org/maven2/com/google/protobuf/protoc/)) in the same way as other artifacts served by maven repositories. Background: particularly useful for defining (lang) proto toolchains, without having to compile nor manually maintain repository mappings (checksums, etc.) for all supported platforms.
rdesgroppes
force-pushed
the
add-preliminary-support-for-exe-packaging-type
branch
from
352ebaa to
40dfd3d
Compare
|
Hi @cheister, may I kindly request a review? |
|
Or @shs96c, maybe? |
shs96c
approved these changes
Jun 8, 2023
| @@ -253,6 +253,10 @@ maven_install( | |||
| group = "com.google.apis", | |||
| version = "v1-rev235-1.25.0", | |||
| ), | |||
| # https://github.com/bazelbuild/rules_jvm_external/issues/907 | |||
| # Any two platforms to ensure that it doesn't work _only_ under the host operating system | |||
There was a problem hiding this comment.
I do thank you, @shs96c, knowing how time-consuming code reviews can be...
This was referenced Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #907.
This is to allow fetching prebuilt binaries (such as protoc) in the same way as other artifacts served by maven repositories.
Background: particularly useful for defining (lang) proto toolchains, without having to compile nor manually maintain repository mappings (checksums, etc.) for all supported platforms.
A few related questions/contributions:
@build_stack_rules_proto//toolchain:prebuilt)