Rework how we determine coordinate formats #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shs96c
force-pushed
the
coords-version-check
branch
2 times, most recently
from
53fecb3 to
c3e59d2
Compare
The assumption that versions begin with numbers is fatally flawed in reality. Fortunately, where we're trying to disambiguate, most of the time, it's safe to assume that people mean a version number rather than some other format.
shs96c
force-pushed
the
coords-version-check
branch
from
c3e59d2 to
20434ab
Compare
|
Can you add a regression tests that cover one of the artifacts used in the issue? |
cheister
reviewed
Feb 7, 2025
tests/unit/coordinates_test.bzl
Outdated
| def _unusual_version_format_impl(ctx): | ||
| env = unittest.begin(ctx) | ||
|
|
||
| unpacked = unpack_coordinates("group:artifact:FY21R16") |
There was a problem hiding this comment.
Should we also add a test for a version that doesn't have any numbers?
cheister
reviewed
Feb 7, 2025
private/coursier_utilities.bzl
Outdated
|
|
||
| # We add "pom" into SUPPORTED_PACKAGING_TYPES here because "pom" is not a | ||
| # packaging type that Coursier CLI accepts. | ||
| if unpacked.get("packaging", None) in SUPPORTED_PACKAGING_TYPES + ["pom"]: |
There was a problem hiding this comment.
TODO for another PR: It looks like SUPPORTED_PACKAGING_TYPES contains "pom" so probably not necessary to add it again here?
There was a problem hiding this comment.
Removed. Nice catch. Thank you
cheister
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assumption that versions begin with numbers is fatally flawed in reality. Fortunately, where we're trying to disambiguate, most of the time, it's safe to assume that people mean a version number rather than some other format.
Closes #1290