Fix java version parsing when _JAVA_OPTIONS are returned from 'java -version' #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheister
force-pushed
the
fix-java-options-in-java-version
branch
from
abec53a to
2420cb1
Compare
shs96c
approved these changes
Apr 27, 2024
copybara-service bot
pushed a commit
to tink-crypto/tink-java-apps
that referenced
this pull request
Jul 2, 2024
Use `rules_jvm_external@4f56f7cec2fa3a47e34d48b8f6293785cfad7e3a` [1] to avoid similar issues to [2] on macOS. This requires using Java 11. [1] bazel-contrib/rules_jvm_external@4f56f7c [2] bazel-contrib/rules_jvm_external#1115 PiperOrigin-RevId: 648704962 Change-Id: Iec949a1a933b0d7f196ea1c7f459545932c10ec1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1069 broke the case where
java -versionreturnsin the first line of the version string