-
-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Saving the nogo fixes #4102
feat: Saving the nogo fixes #4102
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
7b03e4c
to
29f650b
Compare
f506b28
to
c079a7f
Compare
3b49ecb
to
b57424d
Compare
thanks for the comments, i am in the process of addressing them. |
4f41cce
to
f6bab4d
Compare
this shows the log of the latest version: |
47d7bf7
to
ee5bf11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only half way through, posting some comments so far. I will continue later this week
ee5bf11
to
23277ea
Compare
half way, will handle the rest tmr. |
b00b27a
to
d792536
Compare
f4b8542
to
925f99d
Compare
landing is blocked by the central CI infra issue: bazelbuild/continuous-integration#2153. |
rebase on 12/13
stylish changes more stylish changes fixing test on Windows addressing comments fixing the build
625a4b3
to
e4d5930
Compare
What type of PR is this?
What does this PR do? Why is it needed?
nogo analyzers may produce fixes as analysis.Diagnostic. This PR allows rules_go to save the fixes as patches, one per target. The patch and the command to apply the patch is printed out to the terminal for users to manually apply. The patch is also available in the "nogo_fix" output group. This allows people to get patches for all targets without failing the build by passing
--norun_validations --output_groups nogo_fix
.Example output:
Other notes for review
An analyzer may suggest multiple alternative fixes to one issue. Only the first one is selected by default, unless it conflicts with other fixes, in which case it moves on to try the next alternative. If all alternatives are tried but still have conflicts, they will be skipped. In such case, the user will have to apply the patch first, and run nogo again to get the fix to the issue.