upgrade x/tools to v0.12.0 #3678
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade was done with ```bash > bazel run go/tools/releaser -- upgrade-dep org_golang_x_tools ``` after the patch in bazel-contrib#3677. --- A few additional updates needed for this to work: - Update to `tests/integration/popular_repos` to remove unused packages - Update to `nogo` to use the new interface of x/tools Because this upgrade is NOT backward compatible (by design of x/tools repo), downstream users of rules_go are advised to upgrade `x/tools` version in their repo to v0.12.0 or later to avoid breakages.
sluongng
force-pushed
the
sluongng/upgrade-x-tools
branch
from
43f6f88 to
d45110e
Compare
|
@fmeum it looks like Bazel CI is having an issue today. Could you please retry this PR later as well when you have a chance? |
|
may require gazelle to be upgraded to a version that includes bazel-contrib/bazel-gazelle#1603 so that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade was done with
> bazel run go/tools/releaser -- upgrade-dep org_golang_x_toolsafter the patch in #3677.
A few additional updates are needed for this to work:
tests/integration/popular_reposto remove unused packagesnogoto use the new interface of x/toolsBecause this upgrade is NOT backward compatible (by design of x/tools
repo), downstream users of rules_go are advised to upgrade
x/toolsversion in their repo to v0.12.0 or later to avoid breakages.