Migrate to the modern linker input API. #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would also need to change the minimum Bazel version to 3.0.0. |
jayconrod
reviewed
Oct 22, 2020
There was a problem hiding this comment.
Change looks good. CI is down right now (bazelbuild/continuous-integration#1055), so I'll check back on this later.
benjaminp
force-pushed
the
modern-linking
branch
from
1e411ff to
eb6b4b7
Compare
benjaminp
force-pushed
the
modern-linking
branch
from
eb6b4b7 to
858c83c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Migrates cgo code away from deprecated Bazel cc Starlark apis.
Which issues(s) does this PR fix?
Fixes #
Other notes for review
See bazelbuild/bazel#10860.