Migrate for Bazel's --incompatible_require_ctx_in_configure_features #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jayconrod I see your TODO a line above my change regarding toolchain files. |
New Bazel versions require a ctx argument; old versions don't know about it. Also: convert compat_repo.bzl logic into a loop. Adding a new versions should just mean adding a file and adding a number to a list.
|
I changed this a little to go through the compatibility layer. Old versions of Bazel (rules_go supports back to 0.18.0) don't know about the |
jayconrod
deleted the
migrate_for_incompatible_require_ctx_in_configure_features
branch
jayconrod
pushed a commit
that referenced
this pull request
May 15, 2019
…2054) This PR migrates rules_go for Bazel's incompatible change bazelbuild/bazel#7793, which is present in 0.25. New Bazel versions require a ctx argument; old versions don't know about it, so this call is made through the compatibility layer. Also: convert compat_repo.bzl logic into a loop. Adding a new versions should just mean adding a file and adding a number to a list.
jayconrod
pushed a commit
that referenced
this pull request
May 15, 2019
…2054) This PR migrates rules_go for Bazel's incompatible change bazelbuild/bazel#7793, which is present in 0.25. New Bazel versions require a ctx argument; old versions don't know about it, so this call is made through the compatibility layer. Also: convert compat_repo.bzl logic into a loop. Adding a new versions should just mean adding a file and adding a number to a list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates rules_go for Bazel's incompatible change bazelbuild/bazel#7793, which is present in 0.25.