-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OSS-Fuzz support to the Bazel fuzzing rules. #96
Conversation
I still need to update the documentation, but I wanted to first validate with you the implementation, to make sure it properly observes OSS-Fuzz's contracts @inferno-chromium @oliverchang |
Starting another thread to discuss testing: IMO, it would be nice if there was a way to make sure the code works correctly end-to-end on the latest versions of these rules and OSS-Fuzz. @inferno-chromium @oliverchang do you think we should have tests inside the OSS-Fuzz repo, here, or both? If so, any thoughts on how to best test these? My own (manual) testing resorted to create a dummy project (like this) and then making sure the examples in this repo build under that project. Is there a better way to do this during CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
f3981a1
to
911aa6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the feedback! PTAL.
Bumping this up, in case you have any suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting another thread to discuss testing: IMO, it would be nice if there was a way to make sure the code works correctly end-to-end on the latest versions of these rules and OSS-Fuzz.
@inferno-chromium @oliverchang do you think we should have tests inside the OSS-Fuzz repo, here, or both? If so, any thoughts on how to best test these? My own (manual) testing resorted to create a dummy project (like this) and then making sure the examples in this repo build under that project. Is there a better way to do this during CI?Bumping this up, in case you have any suggestion.
Perhaps we can have a GitHub action for this repo which checks out OSS-Fuzz at the latest revision and builds the test project? Seems like something that would fit better in this repo.
Sounds great - let's move the conversation to #105. There are a few details to figure out I think. |
The support includes (a) a repository rule that extracts OSS-Fuzz environment information and makes it available hermetically in a
@rules_fuzzing_oss_fuzz
repo, and (b) a new target in thecc_fuzz_test
macro that packages a fuzz test and its dependencies in the OSS-Fuzz format.