Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules_python and use new deps installer #225

Conversation

keith
Copy link
Member

@keith keith commented Mar 22, 2023

No description provided.

@stefanbucur
Copy link
Collaborator

Thanks a lot for the contribution! It looks like the new rules_python expects a recent Bazel version, as well. We haven't changed the pinned version in a while; if you'd like to fix that, I'd prefer we do it first in a separate PR. Thanks!

@keith
Copy link
Member Author

keith commented Mar 22, 2023

@stefanbucur sounds good, do you want to bump to 5.4 or straight to 6.x?

@stefanbucur
Copy link
Collaborator

@stefanbucur sounds good, do you want to bump to 5.4 or straight to 6.x?

6.x would be great - but in case we run into unexpected incompatibilities that might be non-trivial to fix, 5.4 would be okay as well.

@fmeum
Copy link
Member

fmeum commented Mar 22, 2023

Updating to 6.0 won't just work because rules_fuzzing has a transitive dependency (through Jazzer) on an older version of rules_kotlin, which isn't compatible with Bazel 6. I have a draft PR that would bump the Jazzer dependency in rules_fuzzing, but that requires (since there is no way to pin it) bumping the Jazzer version used in oss-fuzz, which has to be done very carefully.

@keith If you do need 6.0.0 instead of just 5.4.0, let me know and I will try to come up with a shortcut.

@keith
Copy link
Member Author

keith commented Mar 22, 2023

sounds good, not a huge rush for me i just wanted to do the rules_python bump here

@keith keith force-pushed the ks/update-rules_python-and-use-new-deps-installer branch from e38c883 to 9043088 Compare March 24, 2023 17:36
@stefanbucur stefanbucur merged commit 9865504 into bazel-contrib:master Mar 24, 2023
@keith keith deleted the ks/update-rules_python-and-use-new-deps-installer branch March 24, 2023 18:08
@keith
Copy link
Member Author

keith commented Mar 24, 2023

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants