Use Bazel's default PATH when running Python actions
#217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without `use_default_shell_env`, `PATH` was not set for Python actions, which resulted in `python` (or `python3`) not being found.
fmeum
requested review from
asraa,
inferno-chromium,
fniksic,
oliverchang,
stefanbucur and
xinhaoyuan
as code owners
|
@stefanbucur The fix consists of two parts: the first commit of this PR and google/oss-fuzz#9024, which I mocked with the temporary second commit. |
fmeum
force-pushed
the
fix-python-build
branch
from
6ac2f4d to
516c52d
Compare
|
The second commit was no longer necessary, but I saw CI runs fail for a different reason now ( |
|
The Java run fails due to upstream changes in OSS-Fuzz. I will try to fix that separately, but it would be easier if we could get this PR merged first despite that failure. |
fmeum
force-pushed
the
fix-python-build
branch
from
9bf83fb to
921ebed
Compare
ubuntu-latest now resolves to ubuntu-22.04, which does not provide clang-10.
fmeum
force-pushed
the
fix-python-build
branch
from
921ebed to
6a8172f
Compare
|
@stefanbucur The upstream change has been reverted, so this is all green now. |
stefanbucur
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
Thanks! Opened #221 to keep track of the ubuntu-latest issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without
use_default_shell_env,PATHwas not set for Python actions, which resulted inpython(orpython3) not being found.