Remove libFuzzer stub source file #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stub containing the warning is redundant: If it is linked in, then the target depending on it will also pick up the `-fsanitize=fuzzer` flag and thus link in libFuzzer. On macOS, where weak symbols are treated differently by default, the stub can lead to libFuzzer not being linked at all.
fmeum
requested review from
asraa,
inferno-chromium,
fniksic,
oliverchang,
stefanbucur and
xinhaoyuan
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stub containing the warning is redundant: If it is linked in, then the target depending on it will also pick up the
-fsanitize=fuzzerflag and thus link in libFuzzer.On macOS, where weak symbols are treated differently by default, the stub can lead to libFuzzer not being linked at all.