Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bazel_lint job #205

Merged
merged 2 commits into from
May 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/bazel_lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@ jobs:
- uses: actions/setup-go@v2
with:
go-version: '^1.13.1' # The Go version to download (if necessary) and use.
- run: go get github.com/bazelbuild/buildtools/buildifier
- run: go install github.com/bazelbuild/buildtools/buildifier@latest
- run: buildifier -lint=warn -mode=check $(find . -type f \( -name BUILD.bazel -or -name BUILD -or -name *.bzl \))

2 changes: 1 addition & 1 deletion fuzzing/private/binary.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Provider for storing information about a fuzz test binary.
},
)

def _fuzzing_binary_transition_impl(settings, attr):
def _fuzzing_binary_transition_impl(settings, _attr):
opts = instrum_opts.make(
copts = settings["//command_line_option:copt"],
conlyopts = settings["//command_line_option:conlyopt"],
Expand Down
6 changes: 3 additions & 3 deletions fuzzing/private/common.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ Rule for creating a script to run the fuzzing test.
default = Label("//fuzzing/tools:launcher"),
doc = "The launcher script to start the fuzzing test.",
executable = True,
cfg = "host",
cfg = "exec",
),
"binary": attr.label(
executable = True,
Expand Down Expand Up @@ -112,7 +112,7 @@ specified in the srcs attribute.
default = Label("//fuzzing/tools:make_corpus_dir"),
doc = "The tool script to copy and rename the corpus.",
executable = True,
cfg = "host",
cfg = "exec",
),
"srcs": attr.label_list(
doc = "The corpus files for the fuzzing test.",
Expand Down Expand Up @@ -151,7 +151,7 @@ Rule to validate the fuzzing dictionaries and output a merged dictionary.
default = Label("//fuzzing/tools:validate_dict"),
doc = "The tool script to validate and merge the dictionaries.",
executable = True,
cfg = "host",
cfg = "exec",
),
"dicts": attr.label_list(
doc = "The fuzzing dictionaries.",
Expand Down