Use assembly name for DotnetAssembly{Compile,Runtime}Info #435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used the name of the target directly, which caused problems in the following configuration:
publish_binary
uses the name specified inDotnetAssemblyRuntimeInfo
to generate the{assembly}.deps.json
and{assembly}.runtimeinfo.json
files, which are required for the .NET application to run. Since this was set to the target name, the generated filenames in the case above would bebar.deps.json
andbar.runtimeinfo.json
, causing the following error when trying to run the publish target:The default case is unaffected, since
assembly_name
defaults to thename
attribute ifout
is not given.