Fix 'repo_mapping_manifest' property check for compatibility #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
karataliu
changed the title
karataliu
changed the title
|
Could you add a comment that explains why this is needed? |
|
@purkhusid Sure, updated comment in code and PR description. Would you please take another look? Thanks. |
karataliu
force-pushed
the
b6
branch
2 times, most recently
from
7aa6dcf to
8757553
Compare
purkhusid
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making it compatible with bazel6.
repo_mapping_manifestis added toFilesToRunProviderin bazel 7.0 via bazelbuild/bazel#20022Currently the code will access
repo_mapping_manifestdirectly, which makes it only works for bazel >=7.0This fix helps make the code compatible with bazel 6.0 by adding a attr check. When running on bazel 6.0：
Error: 'FilesToRunProvider' value has no field or method 'repo_mapping_manifest'