Make Runfiles library compatible with .NET Standard 2.0 #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit attemps to make the Runfiles library compatible with .NET Standard 2.0 instead of .NET Standard 2.1. The requirement for 2.1 is caused by the use of Path.IsPathFullyQualified(), which only exists for .NET Core 2.0 and later. The implementation of Path.IsPathFullyQualified() has been paraphrased from the code in the .NET runtime source repo. There may be other ways to accomplish this, including changing which references are included, but this seems the least intrusive mechanism.
purkhusid
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit attemps to make the Runfiles library compatible with .NET Standard 2.0 instead of .NET Standard 2.1. The requirement for 2.1 is caused by the use of Path.IsPathFullyQualified(), which only exists for .NET Core 2.0 and later. The implementation of Path.IsPathFullyQualified() has been paraphrased from the code in the .NET runtime source repo.
There may be other ways to accomplish this, including changing which references are included, but this seems the least intrusive mechanism.