Disconnected TFM graphs in non deps attributes #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What? This adds an transition to all label attributes that do not already have the TFM transition. All this transition does it transition the TFM/RID back to the default configuration. ## Why? Because the end user might have labels that are *_binary targets in those attributes but they should not be connected to the actual TFM graph of the build for the owning target. Examples are: Target A uses generated in it's `srcs` attribute coming from target B Target A uses a csharp_binary in it's data dependency because it needs to run the binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This adds an transition to all label attributes that do not already have the TFM transition.
All this transition does it transition the TFM/RID back to the default configuration.
Why?
Because the end user might have labels that are *_binary targets in those attributes but they should not be connected to the actual TFM graph of the build for the owning target.
Examples are:
Target A uses generated in it's
srcsattribute coming from target BTarget A uses a csharp_binary in it's data dependency because it needs to run the binary